Prevent image modification using rolling_ball#2
Open
caeduft wants to merge 1 commit intobnsreenu:masterfrom
Open
Prevent image modification using rolling_ball#2caeduft wants to merge 1 commit intobnsreenu:masterfrom
caeduft wants to merge 1 commit intobnsreenu:masterfrom
Conversation
Subtract_background_rolling_ball (line 57) seems to modify the original image that is used as an argument (even though a different object is created for the output). That is why plotting the original image (line 67) looks like the final image (line 69-70). This issue can also be seen in the YouTube tutorial 43 (min 6:40 - 7:30). To solve this issue, a copy of the image is created, called image_rb (line 55). The copy of the image (image_rb) is used as an argument for subtract_background_rolling_ball (line 57)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtract_background_rolling_ball (line 57) seems to modify the original image that is used as an argument (even though a different object is created for the output). That is why plotting the original image (line 67) looks like the final image (line 69-70). This issue can also be seen in the YouTube tutorial 43 (min 6:40 - 7:30).
To solve this issue, a copy of the image is created, called image_rb (line 55). The copy of the image (image_rb) is used as an argument for subtract_background_rolling_ball (line 57)